fix notifications on list of primitive mixed #4770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a bunch of things in the DeepChangeChecker tests in transaction_log_parsing.cpp which should be copied to also test this scenario. |
tgoyne
reviewed
Jun 18, 2021
Comment on lines
116
to
126
| if (value.is_type(type_TypedLink)) { | ||
| auto link = value.get_link(); | ||
| if (!link.is_unresolved()) { | ||
| if (!cached_linked_table || cached_linked_table->get_key() != link.get_table_key()) { | ||
| cached_linked_table = coll->get_table()->get_parent_group()->get_table(link.get_table_key()); | ||
| REALM_ASSERT_EX(cached_linked_table, link.get_table_key().value); | ||
| } | ||
| return this->check_row(*cached_linked_table, link.get_obj_key().value, depth + 1); | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
It looks like this part of the function is shared between list/set/dictionary and could be extracted to a templated function?
tgoyne
approved these changes
Jun 18, 2021
jedelbo
force-pushed
the
js/observe-list-mixed
branch
from
c79c340 to
8b67efd
Compare
|
Can you have a look at #4646 ? I changed the |
tgoyne
approved these changes
Jun 21, 2021
|
I think it would be fair if #4646 is merged first - assuming this can be done soon. |
|
Looks like we will be doing another v11 release before merging things to master so I will get this in now so it can be included in that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to handle list of Mixed when checking for deep changes in the notification logic.
It's the same code as Set so I extracted it to a templated method. It couldn't be generalized to work on a CollectionBase pointer because this base class doesn't have an iterator interface at that level, and unfortunately it is not trivial to add.
Reported by #4767
☑️ ToDos